Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more file to gitignore #1282

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Added more file to gitignore #1282

merged 2 commits into from
Apr 18, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented Apr 18, 2022

For developing and testing my number of .env-files has increased significantly over the last month. I use these different .env-files as a symlink target and I iterate over them to check the effect of changes for different setups. I always fear to accidentally commit them some day. So I decided it has been time to exclude them.

If anybody has a better idea, I am open to ideas. I don't mind if this PR is rejected.

FYI, my collection of .env-files look like that

  • .env.debug.mysql.empty
  • .env.debug.mysql.geeklihui
  • .env.debug.mysql.ildyria
  • .env.debug.mysql.own
  • .env.production.mysql.empty
  • .env.production.mysql.geeklihui
  • .env.production.mysql.ildyria
  • .env.production.mysql.own
  • .env.testing.mysql.empty
  • .env.debug.psql.empty
  • .env.debug.psql.own
  • .env.production.psql.empty
  • .env.production.psql.own
  • .env.testing.psql.empty
  • .env.debug.sqlite.empty
  • .env.production.sqlite.empty
  • .env.testing.sqlite.empty

@nagmat84 nagmat84 requested a review from ildyria April 18, 2022 13:48
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions on the overall idea because I don't have lots of these kicking around, but I'm gently in favour.

.gitignore Outdated
Comment on lines 35 to 37
.env.*
!.env.example
!.env.homestead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.env.*
!.env.example
!.env.homestead
.env*

Files manually added to the index aren't affected by .gitignore (and still show as changed when they're updated), so I'd just ignore all of them.

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing against.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1282 (f03feb5) into master (2d80ba6) will decrease coverage by 0.96%.
The diff coverage is n/a.

@nagmat84 nagmat84 merged commit db0c51f into master Apr 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the update_gitignore branch April 18, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants