Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale variable #1291

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Add locale variable #1291

merged 2 commits into from
Apr 27, 2022

Conversation

qwerty287
Copy link
Contributor

Replaces #1288.

@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1291 (859370f) into master (601b5b7) will decrease coverage by 1.27%.
The diff coverage is 0.00%.

nagmat84
nagmat84 requested changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it. Personally, I don't use the view page of Lychee. So maybe @ildyria can test it. In only have a single CR.

app/Http/Controllers/ViewController.php Outdated Show resolved Hide resolved
@nagmat84 nagmat84 requested a review from ildyria April 25, 2022 17:53
@kamil4
Copy link
Contributor

kamil4 commented Apr 25, 2022

I haven't tested it. Personally, I don't use the view page of Lychee. So maybe @ildyria can test it. In only have a single CR.

Share Photo / Direct Links -- first link on top. Open preferably in a different browser session (one that is not authenticated with the server).

@ildyria ildyria requested a review from nagmat84 April 27, 2022 11:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ildyria
ildyria approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ildyria ildyria mentioned this pull request Apr 27, 2022
Closed
nagmat84
nagmat84 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ildyria ildyria merged commit 75aa06d into LycheeOrg:master Apr 27, 2022
@qwerty287
Copy link
Contributor Author

@ildyria thanks for fixing

@qwerty287 qwerty287 deleted the view-tmpl branch May 5, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwerty287 @kamil4 @ildyria @nagmat84