Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coloring in scripts #1305

Merged
merged 2 commits into from
May 7, 2022
Merged

Fix coloring in scripts #1305

merged 2 commits into from
May 7, 2022

Conversation

qwerty287
Copy link
Contributor

Must use printf instead of echo. Tested with bash and zsh.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1305 (3905405) into master (50dacef) will decrease coverage by 0.89%.
The diff coverage is n/a.

❗ Current head 3905405 differs from pull request most recent head d598114. Consider uploading reports for the commit d598114 to get more accurate results

scripts/install_files.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That makes a lot of sense. I was constantly bothered by seeing ANSI control sequences in my terminal, but I did not feel summoned to look into it.

Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
@qwerty287 qwerty287 merged commit ddb1ddc into master May 7, 2022
@qwerty287 qwerty287 deleted the fix-hook-color branch May 7, 2022 05:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants