Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1311 #1317

Merged
merged 1 commit into from
May 9, 2022
Merged

Fixes #1311 #1317

merged 1 commit into from
May 9, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented May 9, 2022

Recursive import from the server into the root albums failed with

2022-05-08 20:42:24 UTC -- error -- App\Actions\Import\Exec::do -- 313 -- Attempt to read property "id" on null

due to this line

->​where​(​'albums.parent_id'​, ​'='​, ​$​parentAlbum​->​id​)

which should have been

->​where​(​'albums.parent_id'​, ​'='​, ​$​parentAlbum​?->​id​)

This fixes #1311. The OP already confirmed that the fix works.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nagmat84 nagmat84 requested a review from qwerty287 May 9, 2022 17:03
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1317 (2848e96) into master (1344cb4) will decrease coverage by 0.89%.
The diff coverage is 50.00%.

@qwerty287 qwerty287 merged commit 7a0c791 into master May 9, 2022
@qwerty287 qwerty287 deleted the fix_1311 branch May 9, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Attempt to read property "id" on null" error when importing new folder using symlinks
2 participants
@nagmat84 @qwerty287