Make Linter happy about tests #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
d7415
reviewed
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really trivial and annoying PR, because it changes nothing on the functional level.
For my up-comping PR on use_filestreams after #1309 has been merged, I promised 85% test coverage for the stuff in /app/Image/ and /app/Actions/Photo/. So I am busy adding tests to use_filestreams.
However, I want to get some "trivial" stuff in /tests out of the way so that the eventual PR is not littered.
This PR changes three aspects:
Make the Linter happy; adding return types everywhere, etc. pp.
Added helper methods in
TestCaseto createUploadedFilesobjects. I will need that a lot in the upcoming PR and I don't want to repeat boiler-plate code. This has also reduced some existing boiler plate code already.Re-organized the files around photo tests. Now there are three instead of two:
PhotosAddTests: contains tests from the previousPhotosTestsPhotosOperationTests: contains tests from the previousPhotosTestsPhotosRotateTest: same as beforeThe reason why I split the former
PhotosTestis again the upcoming PR. There will be a lot of new tests inPhotosAddTestsfor the various combinations we support. So I don't wanted to get the oldPhotosTeststoo crowded. It is also calledPhotosAddTests(instead ofPhotosUploadTests) on purpose: a) we also have imports; b) this way it comes beforePhotoOperationsin the alphabetical order and we should test photo uploads first before we operate on them.