Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test samples for pending PR. #1352

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Test samples for pending PR. #1352

merged 4 commits into from
Jun 2, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented May 29, 2022

This PR only adds the test samples to the master branch which are required by #1351. The test cases for import via URL download use URLs like these

public const SAMPLE_DOWNLOAD_JPG = 'https://github.com/LycheeOrg/Lychee/raw/master/tests/Samples/mongolia.jpeg';
public const SAMPLE_DOWNLOAD_TIFF = 'https://github.com/LycheeOrg/Lychee/raw/use_filestreams/tests/Samples/tiff.tif';

To ensure that the test suite runs for the development branch use_filestreams before the merge and the master branch after the merge all URLs must already point to the master branch. However, this requires that the sample files are independently merged into master at first.

I added the EXIF tag Location to the header of the sample file night.jpg, because the related branch in the EXIF reader was untested. That's why the file is 266 bytes larger and appears as changed.

@nagmat84 nagmat84 requested review from d7415 and ildyria May 29, 2022 17:04
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #1352 (b931f33) into master (9174540) will decrease coverage by 0.88%.
The diff coverage is n/a.

@nagmat84 nagmat84 changed the title Test samples for upcoming PR. Test samples for pending PR. May 29, 2022
@nagmat84 nagmat84 mentioned this pull request May 29, 2022
tests/TestCase.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria ildyria merged commit f866214 into master Jun 2, 2022
@nagmat84 nagmat84 deleted the add_test_samples branch June 6, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants