Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing photos var and add photo title #1360

Merged
merged 3 commits into from
Jun 4, 2022
Merged

Fix missing photos var and add photo title #1360

merged 3 commits into from
Jun 4, 2022

Conversation

qwerty287
Copy link
Contributor

Just add the variable photos to fix #1354. Also adds a var title with the photo's title set a alt text for the image.

@qwerty287 qwerty287 requested review from ildyria, nagmat84 and kamil4 June 4, 2022 07:14
@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

Merging #1360 (e5effc3) into master (68d60df) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

nagmat84
nagmat84 approved these changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but untested because I have no mail server configured. I have a minor suggestion, but I am not sure about that.

resources/views/view.blade.php Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nagmat84
Copy link
Collaborator

nagmat84 commented Jun 4, 2022

IMHO, it can be merged.

@qwerty287 qwerty287 merged commit 02ee1c3 into master Jun 4, 2022
@qwerty287 qwerty287 deleted the fix-photos-mail branch June 4, 2022 14:39
@qwerty287
Copy link
Contributor Author

Then feel free to do it the next time, you don't have to wait for me :)

@nagmat84
Copy link
Collaborator

nagmat84 commented Jun 4, 2022

I was not sure if you wanted to wait for a second review. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

@ildyria ildyria Awaiting requested review from ildyria

@kamil4 kamil4 Awaiting requested review from kamil4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications emails not sending
2 participants
@qwerty287 @nagmat84