Update PHPExif and sync frontend #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagmat84
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
LGTM. Just one minor question (see below). Maybe we can also use this PR to sync the frontend again? I prefer to avoid having too many "trivial" commits on master. Maybe we could call this PR "Update PHPExif + Sync of Frontend"?
But this is only a personal taste. I am also happy to open new PR just for syncing the frontend.
|
I am confused did you also compile the frontend, when you synced the submodule to the updated head of master? I had expected to see changed JS files in |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yes, forgot that, but pushed new commits containing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHPExif blocked the update of PHP-FFMpeg (https://github.com/LycheeOrg/php-exif/releases/tag/v0.7.6), I updated this again. PHP-FFMpeg contains no breaking changes (this PR is kind of a followup to #1337).