Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extractor uses EXIFtool for all types of media, if available. #1379

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Extractor uses EXIFtool for all types of media, if available. #1379

merged 1 commit into from
Jun 26, 2022

Conversation

nagmat84
Copy link
Collaborator

As discussed on Gitter at 25. Juni 2022 21:25 and at 26. Juni 2022 10:07.

This PR reverts to the old behavior to use EXIFtool for all kind of media files (video, photos and raw).

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #1379 (492c438) into master (8511ea7) will decrease coverage by 0.86%.
The diff coverage is 77.77%.

@nagmat84 nagmat84 requested review from ildyria and kamil4 June 26, 2022 08:38
ildyria
ildyria approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nagmat84 nagmat84 merged commit 01541c3 into master Jun 26, 2022
@qwerty287 qwerty287 deleted the use_exiftool_for_all_media branch June 26, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@ildyria ildyria ildyria approved these changes

@kamil4 kamil4 Awaiting requested review from kamil4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nagmat84 @ildyria @qwerty287