Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve safety and reliability of lychee:ghostbuster #1405

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Improve safety and reliability of lychee:ghostbuster #1405

merged 1 commit into from
Jul 11, 2022

Conversation

nagmat84
Copy link
Collaborator

While working on my other PR, I noticed that lychee:ghostbuster became a victim of the recent addition of PHPstan. The comparison with === 1 or === '1' is not reliable, because sometimes the framework returns an int and sometimes a string.

In case of dryrun this is extremely dangerous, because dryrun could accidentally be set to false. This PR should fix it.

@nagmat84 nagmat84 requested a review from ildyria July 11, 2022 16:25
@ildyria
Copy link
Member

ildyria commented Jul 11, 2022

because sometimes the framework returns an int and sometimes a string.

FFS...

ildyria
ildyria approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nagmat84 nagmat84 merged commit 985f6f8 into master Jul 11, 2022
@ildyria ildyria deleted the fix_ghostbuster branch July 13, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nagmat84 @ildyria