Improve cicd

[ildyria]

• add a linter step to catch early php syntax error.
• Add more structure and unify the CI.
• Still run test even if code style fails.
• Add support for artifact upload on master branch (which aims to simulate a master release build).

[codecov]

Codecov Report

Merging #1424 (5bb6949) into master (1064f04) will decrease coverage by 0.81%.
The diff coverage is n/a.

[nagmat84]

I only have limited understanding of Github workflow files. I checked out the old Build.yml and did a manual diff with the new CICD.yml on my local machine as Github does not recognize that CICD.yml is basically a merger of Build.yml and phpstan.yml plus some additions. From what I have seen it looks sane.

As I cannot say much about the workflow on the semantic level, I only have some less important comments about the syntax. I simply noticed some inconsistencies.

[ildyria]

I will standardize the strings with double quotes (even though they are not necessary per say).

[ildyria]

The big difference is that there are dependencies between the different parts of the runs to potentially fail early.
https://github.com/LycheeOrg/Lychee/actions/runs/2768728603

I just hope that the build artifact step will work on master. This should allow us to have a "release-like" zip file built on each commit on master, potentially allowing us to give the "lastest" build from master without having to build a formal release. :)

[nagmat84]

With my little understand it looks good. Maybe we should just give it a try. 🙈

[nagmat84]

I will standardize the strings with double quotes (even though they are not necessary per say).

I believe you decided for without double quotes.

[nagmat84]

Sorry, I just spotted that after I had a look on the dependency graph. I believe we want to check for syntax errors here.

[ildyria]

Addressed:

• reordering of the task and dependency
• removing superfluous apt
• zip no longer only on master
• zip the zip.

[d7415]

Apparently GitHub Actions diagrams are terrible at showing dependencies clearly

(I accept that's a non-trivial task, and the interactive nature helps a lot, but it's still annoying)