Add csp exceptions #1551
Merged
Add csp exceptions #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
approved these changes
Oct 8, 2022
| @@ -103,6 +103,8 @@ | |||
| </form> | |||
| </div> | |||
| </div> | |||
| <!-- Do not change even a single character in the block below without | |||
| also updating the checksum in config/secure-headers.php! --> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a handful of inline event handlers and a single inline script via CSP hashes. I'm guessing that at least
upload.check()won't be needed when @nagmat84's improved basicModal gets merged.Removes one inline script that hasn't been needed for a good while, actually.
While with these changes Lychee works as expected again under both Firefox and Chrome, in either case there are warnings in the JS console. Firefox doesn't recognize the
unsafe-hasheskeyword, which is needed to get Chrome to work as expected. Chrome, on the other hand, complains about a number of permission policies:ambient-light-sensor,battery, and more. I can't help feeling that we are perhaps operating too close to the bleeding edge when it comes to our use of CSP...Also updates php-exif to 0.7.12 in
composer.json(it was already that way incomposer.lock).