add descriptions to configuration items #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil4
previously requested changes
Nov 8, 2022
There was a problem hiding this comment.
Overall I think this is a move in the right direction. Further uniformization of the descriptions should be possible though (Enable vs Enables, etc.), although how we would prevent it from drifting over time, I have no idea...
This will definitely conflict with another pending PR.
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
database/migrations/2022_11_07_171403_add_config_descriptions.php
Outdated
Show resolved
Hide resolved
Merged
Co-authored-by: Kamil Iskra <kamil.01482@iskra.name>
Not if it is merged before and we make sure that the migrations are applied in the right order. |
|
@kamil4 Fixed all your changes request. I also checked, |
|
@kamil4 ? :) |
qwerty287
approved these changes
Nov 26, 2022
ildyria
dismissed
kamil4’s stale review
Addressed but Kamil does not reply. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fill the description fields of the config table.