Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to change upload date & fix API token auth #1591

Merged
merged 12 commits into from
Nov 23, 2022
Merged

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Nov 16, 2022

Closes #984

Adds Photo::setUploadDate and fixes a bug of the API token auth that tried to read the token from the header called token while it should read Authorization.

Associated front-end LycheeOrg/Lychee-front#353

@qwerty287 qwerty287 added this to the 4.6.3 milestone Nov 16, 2022
@qwerty287 qwerty287 requested a review from a team November 16, 2022 14:36
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1591 (742008d) into master (b7e2b23) will decrease coverage by 0.82%.
The diff coverage is 100.00%.

❗ Current head 742008d differs from pull request most recent head cc38691. Consider uploading reports for the commit cc38691 to get more accurate results

Additional details and impacted files

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@qwerty287 feel free to review the front-end I proposed.

@qwerty287
Copy link
Contributor Author

Thanks, please don't merge yet. There's an improvement I'd like to add to this. If the new upload date is after the current updated_at, this should be changed as well.

@qwerty287 qwerty287 requested a review from ildyria November 23, 2022 18:05
@qwerty287 qwerty287 requested a review from ildyria November 23, 2022 18:07
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested.

@ildyria ildyria merged commit 2fe2db2 into master Nov 23, 2022
@ildyria ildyria deleted the set-upload-date branch November 23, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] API to set photo upload date
2 participants