Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove and clean up unused files #1649

Merged
merged 6 commits into from
Dec 23, 2022
Merged

Remove and clean up unused files #1649

merged 6 commits into from
Dec 23, 2022

Conversation

qwerty287
Copy link
Contributor

  • remove unused font files
  • convert cat.jpg to WEBP (much smaller size, about 1MB less at all)
  • removed JS source maps: If you don't think this is good, I can undo it. However, I'm not sure if we should keep them because they are limited to two source maps, while the frontend.js has six references. In addition, this copied the full source code of the leaflet.markercluster library, which is definitely useless.

@qwerty287
Various cleanups to minimize size
4cf7f87 
- remove unused font and other files
- convert `cat.jpg` to WEBP (smaller)
@qwerty287
Remove JS source maps
cac4ac4
@qwerty287
Rename Makefile and remove duplicated ;
f6c5909
@qwerty287 qwerty287 requested a review from a team December 22, 2022 07:11
@qwerty287 qwerty287 mentioned this pull request Dec 22, 2022
Merged
@codecov
Copy link

codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #1649 (587f2c1) into master (1dee31e) will decrease coverage by 0.32%.
The diff coverage is n/a.

Additional details and impacted files

@qwerty287 qwerty287 added this to the 4.6.4 milestone Dec 22, 2022
ildyria
ildyria approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM.

@qwerty287 qwerty287 merged commit 5b0d944 into master Dec 23, 2022
@qwerty287 qwerty287 deleted the rm-files branch December 23, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@qwerty287 @ildyria