Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New install page for admin + redirection #1660

Merged
merged 6 commits into from
Dec 25, 2022
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 24, 2022

  • add install step in the web installer screen.
  • redirect to that page if an admin user does not exists
  • add various securities.

@ildyria ildyria requested a review from a team December 24, 2022 23:28
@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Merging #1660 (9ff238b) into user-installation (561a280) will decrease coverage by 0.32%.
The diff coverage is 65.00%.

Additional details and impacted files

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but didn't test myself.

@ildyria
Copy link
Member Author

ildyria commented Dec 25, 2022

Looks good, but didn't test myself.

I did :)

@ildyria
Copy link
Member Author

ildyria commented Dec 25, 2022

When no admin exists, we are redirected here:
image

When DB is not writable or for some other reason:
image

On success:
image

When trying to access again:
image

@ildyria ildyria merged commit 5bad493 into user-installation Dec 25, 2022
@ildyria ildyria deleted the install-step branch December 25, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants