Optimizing sql and improved Log data #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
force-pushed
the
wip-optimizing-sql
branch
from
f3db51d to
7058eff
Compare
ildyria
added
the
Review: easy
qwerty287
approved these changes
Jun 23, 2023
ildyria
added a commit
that referenced
this pull request
Jun 24, 2023
* optimizing sql * remove 2 relations, make sure that permissions are preloaded to avoid n+1 problem * add Explain to mysql queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet a silver bullet but this will allow better investigations of why such slowdown when we have a lot of albums.
And this remove the n+1 query problem we had.