Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve explain on db_logging #1898

Merged
merged 3 commits into from
Jun 24, 2023
Merged

Improve explain on db_logging #1898

merged 3 commits into from
Jun 24, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 24, 2023

No description provided.

@@ -30,6 +30,7 @@ public function setUp(): void
{
parent::setUp();
$this->setUpRequiresEmptyWebAuthnCredentials();
config(['app.url' => 'https://localhost']);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows to just run tests locally without having to think whether the .env matches on not.

@ildyria ildyria marked this pull request as ready for review June 24, 2023 10:13
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #1898 (2cc1b16) into master (7103c0b) will increase coverage by 1.98%.
The diff coverage is 100.00%.

Additional details and impacted files

@ildyria ildyria merged commit 94f670a into master Jun 24, 2023
@ildyria ildyria deleted the better-explain branch June 24, 2023 14:25
ildyria added a commit that referenced this pull request Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants