Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ratio #1925

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Support ratio #1925

merged 2 commits into from
Jul 10, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jul 7, 2023

This adds support for ratio inside the DB.
This will be needed by the livewire front-end to quickly choose a hero image (we want a landscape image).
Unfortunately if we do not pre-compute this, it slows down the search as it relies on file_sort.
For this reason, it is more interesting to support the data directly in the database.

@ildyria ildyria requested a review from a team July 7, 2023 15:24
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1925 (a360ad9) into master (a52fd8e) will decrease coverage by 0.48%.
The diff coverage is 100.00%.

Additional details and impacted files

@ildyria ildyria modified the milestones: 4.10.0, 4.9.5 Jul 10, 2023
@qwerty287 qwerty287 merged commit a532fa4 into master Jul 10, 2023
@qwerty287 qwerty287 deleted the support_ratio branch July 10, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants