Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OSM subdomains #1936

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Remove OSM subdomains #1936

merged 2 commits into from
Jul 11, 2023

Conversation

qwerty287
Copy link
Contributor

Closes #1934

@qwerty287 qwerty287 requested a review from a team July 10, 2023 18:13
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #1936 (a2cecc3) into master (6303e66) will decrease coverage by 0.32%.
The diff coverage is n/a.

❗ Current head a2cecc3 differs from pull request most recent head 4261a2a. Consider uploading reports for the commit 4261a2a to get more accurate results

Additional details and impacted files

@qwerty287 qwerty287 merged commit 939dfbb into master Jul 11, 2023
@qwerty287 qwerty287 deleted the osm-domain branch July 11, 2023 05:58
otbutz
otbutz reviewed Jul 11, 2023
View reviewed changes
config/secure-headers.php
'https://a.tile.osm.org/',
'https://b.tile.osm.org/',
'https://c.tile.osm.org/',
'https://tile.osm.org/',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwerty287 shouldn't that be https://tile.openstreetmap.org/ ? The frontend seems to be using the correct tile URLs though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otbutz otbutz otbutz left review comments

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of legacy OpenStreetMap tile URLs
3 participants
@qwerty287 @ildyria @otbutz