-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1751 - Add error thrown if APP_URL does not match current url #1985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if setting APP_URL with a subpath? Is this allowed or would this be a wrong configuration?
Good point, I adapted the code to throw a warning in such cases: |
Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether it's worth adding validation for subpaths (or the host of APP_URL
s containing them), but that can always be added later.
Untested, as usual.
Not sure if you understood my point, but my question actually was: What happens with both domain and subpath? I.e. |
At a glance, it looks like it is. |
https://www.w3.org/TR/webauthn-2/#rp-id
|
Fixes #1751
This aims to avoid some of the confusions "why is U2F not working?".