Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1686 by providing absolute path if not set #1998

Merged
merged 1 commit into from
Sep 3, 2023
Merged

fixes #1686 by providing absolute path if not set #1998

merged 1 commit into from
Sep 3, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 2, 2023 •
edited
Loading

Fixes #1686

I believe this is because the value of LYCHEE_UPLOADS_URL is not set in your .env
By default the value is upload/ but if you load this in a mail client, I believe this will not be working.

@ildyria ildyria self-assigned this Sep 2, 2023
@ildyria ildyria requested a review from a team September 2, 2023 21:03
@ildyria ildyria added this to the 4.11.1 milestone Sep 2, 2023
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Sep 2, 2023
@codecov
Copy link

codecov bot commented Sep 2, 2023 •
edited
Loading

Codecov Report

Merging #1998 (bf76ebf) into master (cc9a6d4) will decrease coverage by 0.26%.
The diff coverage is n/a.

Additional details and impacted files

d7415
d7415 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Untested.

@ildyria ildyria merged commit 4fc6a14 into master Sep 3, 2023
@ildyria ildyria deleted the fix-1686 branch September 3, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees

@ildyria ildyria

Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.11.1
Development

Successfully merging this pull request may close these issues.

New Photos Email Has Broken Thumbnails
2 participants
@ildyria @d7415