Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes in prevision for Livewire. #2026

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Minor changes in prevision for Livewire. #2026

merged 1 commit into from
Sep 23, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 23, 2023 •
edited
Loading

  • use dev instead of testing to avoid some problems when running tests.
  • Add matrix on tests suite to target which part of the application is broken
  • Improve gitignore
  • Size conversions moved to helpers + remove dead vars.
  • Fix missing photo policy

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Sep 23, 2023
@ildyria ildyria requested a review from a team September 23, 2023 14:31
@ildyria ildyria added this to the 4.13 milestone Sep 23, 2023
@ildyria ildyria marked this pull request as ready for review September 23, 2023 14:32
@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #2026 (8131e1a) into master (4c4745f) will decrease coverage by 0.04%.
The diff coverage is 85.71%.

Additional details and impacted files

@ildyria ildyria merged commit 7111f65 into master Sep 23, 2023
@ildyria ildyria deleted the improve-tests-and-more branch September 23, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287