Fix sub-albums sorting not being respected per album #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
the
Review: easy
ildyria
commented
Oct 30, 2024
| * | ||
| * @codeCoverageIgnore | ||
| */ | ||
| public function exceptionTraceToText(\Exception $e): string |
There was a problem hiding this comment.
Not used in the PR, but quite useful when debugging:
dd($var, Helpers::exceptionTraceToText(new Exception))Will dump the value of $var in a 500 and followed by the trace of where the dump happened.
The front-end is already taking care of making it a nice visual :)
ildyria
commented
Oct 30, 2024
| */ | ||
| public function getEffectiveAlbumSorting(): AlbumSortingCriterion | ||
| { | ||
| return $this->getAlbumSortingAttribute() ?? AlbumSortingCriterion::createDefault(); |
There was a problem hiding this comment.
getAlbumSortingAttribute() is defined on line 448 of the same file.
d7415
approved these changes
Oct 30, 2024
Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
aSouchereau
pushed a commit
that referenced
this pull request
Nov 9, 2024
* fix sub-albums sorting not being respected per album * Update app/Models/Album.php Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com> --------- Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This thing has been plaguing us for a while.
Finally found the proper fix.