Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building artifact in Integrate workflow #2634

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix building artifact in Integrate workflow #2634

merged 1 commit into from
Oct 31, 2024

Conversation

d7415
Copy link
Contributor

@d7415 d7415 commented Oct 30, 2024

The artifact was being uploaded (in the next step) as Lychee-Dist.zip, but the Makefile only creates Lychee.zip, so we should be able to stick with that throughout.

@d7415 d7415 requested a review from ildyria October 30, 2024 23:16
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (0f9225c) to head (d964f63).
Report is 2 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit afd345a into master Oct 31, 2024
49 checks passed
@ildyria ildyria deleted the fix_workflow branch October 31, 2024 06:57
aSouchereau pushed a commit that referenced this pull request Nov 9, 2024
@d7415 @aSouchereau
Fix building artifact in Integrate workflow (#2634)
4a20cb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d7415 @ildyria