Fix hidden gallery footer social icons #2788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2501
The linked issue is reproducible for me in v6.1.2. The icons are visible in the landing page footer, but not in the gallery footer.
I think there's 2 issues with the gallery footer:
Lychee/resources/js/components/footers/GalleryFooter.vue
Lines 8 to 16 in 2e873f3
The first is that the div has
style="display: none"
. This hides the entire div even whenfooter_show_social_media
is enabled. If I override the style to display the div in chrome devtools, I can see the div, but get the square boxes as shown in the original report.The second issue is that the font with the icons is tied to the
socials
class, but the gallery footer links only setsocialicons
. (This is what causes the square boxes)Lychee/resources/sass/fonts.css
Lines 46 to 48 in 2e873f3
You can see that the correctly working landing page footer sets both
socials
andsocialicons
classes:Lychee/resources/js/components/footers/LandingFooter.vue
Lines 3 to 11 in 2e873f3