Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden gallery footer social icons #2788

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Dec 7, 2024

Fixes #2501

The linked issue is reproducible for me in v6.1.2. The icons are visible in the landing page footer, but not in the gallery footer.

I think there's 2 issues with the gallery footer:

<div id="home_socials" class="w-full" style="display: none" v-if="footerData.footer_show_social_media">
<a
v-if="footerData.sm_facebook_url !== ''"
:href="footerData.sm_facebook_url"
class="socialicons"
id="facebook"
target="_blank"
rel="noopener"
></a>

The first is that the div has style="display: none". This hides the entire div even when footer_show_social_media is enabled. If I override the style to display the div in chrome devtools, I can see the div, but get the square boxes as shown in the original report.

The second issue is that the font with the icons is tied to the socials class, but the gallery footer links only set socialicons. (This is what causes the square boxes)

.socials {
font-family: "socials" !important;
}

You can see that the correctly working landing page footer sets both socials and socialicons classes:

<div id="home_socials" class="fixed bottom-8 left-0 right-0 text-center z-10 opacity-0 translate-y-[300px] animate-landingAnimateUp">
<a
v-if="props.footerData.sm_facebook_url !== ''"
:href="props.footerData.sm_facebook_url"
class="inline-block hover:scale-150 hover:text-muted-color transition-all ease-in-out duration-300 text-surface-0 socials text-2xl my-4 mx-5 socialicons"
id="facebook"
target="_blank"
rel="noopener"
></a>

@ildyria
Copy link
Member

ildyria commented Dec 7, 2024

Thank you for your investigation and PR. I'll meege as soon as this passes the CI checks.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (2e873f3) to head (0dbeeab).
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit ee2dba0 into LycheeOrg:master Dec 7, 2024
32 checks passed
@pmrowla pmrowla deleted the 2501-gallery-footer-socials branch December 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants