Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend part of Duplicate Finder #2890

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 10, 2025

(Will not work without the Backend part).

fixes #1762

image

@ildyria ildyria requested a review from d7415 January 10, 2025 10:28
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 10, 2025
@ildyria ildyria added this to the 6.3 milestone Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (79fada4) to head (766651b).
Report is 14 commits behind head on master.

Additional details and impacted files

@ildyria ildyria force-pushed the duplicate-finder-frontend branch from fdb2ac2 to bb168cb Compare January 26, 2025 17:05
@ildyria ildyria requested a review from a team as a code owner January 26, 2025 17:05
|--------------------------------------------------------------------------
*/
'title' => 'Maintenance',
'intro' => 'On this page you will find the duplicates pictures found in your database.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'intro' => 'On this page you will find the duplicates pictures found in your database.',
'intro' => 'On this page you will find the duplicate pictures found in your database.',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 766651b

Comment on lines 27 to 28
'duplicates-title' => 'Title duplicates per albums',
'duplicates-per-album' => 'Duplicates per albums',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'duplicates-title' => 'Title duplicates per albums',
'duplicates-per-album' => 'Duplicates per albums',
'duplicates-title' => 'Title duplicates per album',
'duplicates-per-album' => 'Duplicates per album',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 766651b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove Duplicates
2 participants