Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs Homestead #29

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Conversation

hermzz
Copy link
Contributor

@hermzz hermzz commented Jan 11, 2019

It seems we're all using vagrant/homestead, might as well make it easier
for newcomers to setup their dev machine.

I noticed the Homestead.yaml file is in the .gitignore. Maybe it makes sense to create a basic Homestead.yaml.dist?

It seems we're all using vagrant/homestead, might as well make it easier
for newcomers to setup their dev machine.
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not use Vagrant/Homestead but I agree with this PR.
Can you check if the two points I mentioned are necessary, if so, please advise and this will be merged. 👍

aliases Outdated Show resolved Hide resolved
aliases Outdated Show resolved Hide resolved
@ildyria
Copy link
Member

ildyria commented Jan 11, 2019

@bennettscience you are Using Vagrant I think, can you check this?

@bennettscience
Copy link
Contributor

I don't see any problem with it, but I'm not sure about the "we're all using Vagrant" comment. I tend to shy away from dependency bloat, especially if you're using a low-bandwidth connection (like myself). But, that's mainly personal preference rather than long-term project usability.

Another, more general concern, is that this would overwrite environments already configured on the next pull.

@ildyria
Copy link
Member

ildyria commented Jan 11, 2019

Another, more general concern, is that this would overwrite environments already configured on the next pull.

What do you mean ?

@bennettscience
Copy link
Contributor

Nevermind...it's been a long day. I was concerned that adding a tracked Vagrantfile to the repo would overwrite mine (or someone else's), which is already configured. But if it's untracked, it should be okay.

@bennettscience bennettscience merged commit 06d7127 into LycheeOrg:master Jan 11, 2019
@d7415
Copy link
Contributor

d7415 commented Jan 12, 2019

I tend to shy away from dependency bloat

Late to the party but I strongly agree with this. I'm not convinced that pulling the dev dependencies should automatically install homestead if only one dev is using it...

ildyria pushed a commit that referenced this pull request Jan 12, 2019
* Installs Homestead
* Removes unused aliases
@ildyria
Copy link
Member

ildyria commented Jan 12, 2019

I broke the history tree (my bad). Just fixed it...
You might want to do a

# just to be sure create a save branch
git checkout -b save
# switch back to master
git checkout master

# reset 5 commits
git reset --hard HEAD~5

# pull the new history
git pull origin master

# compare the changes with the save branch and cherry pick the commits you are missing on the save branch
git cherry-pick <commit id>
...
git push

@hermzz
Copy link
Contributor Author

hermzz commented Jan 12, 2019

Regarding bloat: the two new composer packages (laravel/homestead and symfony/yaml) come at under 1MB, given that the current vendor/ folder sits at ~60MB I don't think this a huge deal. I think making this more dev friendly is worth the extra MB.

@d7415
Copy link
Contributor

d7415 commented Jan 12, 2019

given that the current vendor/ folder sits at ~60MB

That's its own problem...

making this more dev friendly

Agreed in principle, but I think that's a stretch if you're the only developer using it.

It's merged now anyway.

@hermzz hermzz deleted the homestead-vagrant branch February 2, 2019 21:50
@Aleshus
Copy link
Contributor

Aleshus commented Aug 6, 2020

Can someone show his Homestead.yml here? I am getting 404 - No input file specified. on /php/index.php (Session::init) . I think that the project cant find SessionController.php but I dont know why for now.

Thanks

@ildyria
Copy link
Member

ildyria commented Aug 6, 2020

Sadly aside from Hermzz none of use use homestead.

I know that there is this:
https://github.com/LycheeOrg/Lychee/blob/master/Vagrantfile

and I also know that @trigun539 seems to have managed to get this working #654 (comment)

If someone would provide us with a Homestead.yml we would happily merge it.

@trigun539
Copy link

Hello all, here is the Homestead.yaml that I used.

---
ip: "192.168.10.10"
memory: 2048
cpus: 2
provider: virtualbox

authorize: ~/.ssh/id_rsa.pub

keys:
    - ~/.ssh/id_rsa

folders:
    - map: ~/opensource/Lychee
      to: /var/www/html/Lychee
    - map: ~/opensource/LycheeOrg.github.io
      to: /var/www/html/LycheeOrg.github.io

sites:
    - map: lychee.test
      to: /var/www/html/Lychee/public
    - map: lycheeorg.test
      to: /var/www/html/LycheeOrg.github.io

databases:
    - homestead

features:
    - mariadb: false
    - ohmyzsh: true
    - webdriver: false

The one extra item to do is update your /etc/hosts file to the following, add the following line:

192.168.10.10 lychee.test lycheeorg.test

After this, you should be able to run both the lychee org site and the lychee application. Hope this helps.

@Aleshus
Copy link
Contributor

Aleshus commented Aug 7, 2020

Ok, I found the issue with 404 - No input file specified. There is a discusion about it here : #52 and when clean new vagrant instance is started, nginx configuration is broken. Second issue is that image is not able to update packages. It looks like it is very old image :)

You all who dont use vagrant, you are on docker? I looked fastly on this https://github.com/LycheeOrg/Lychee-Docker/blob/master/Dockerfile and I think that for develop puposes it needs some tweeks - install ssh, xdebug etc......

@ildyria
Copy link
Member

ildyria commented Aug 7, 2020

To develop I use Virtualbox, here is my setup : https://lycheeorg.github.io/docs/distributions.html#virtualbox-with-visual-studio-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants