feat: add share_button_visible option

[yoshinorin]

Description

I have already read #293. I have the same opinion with @CountCypher.

I want to publish my photo with public permission but I don't want the lychee to appear the share button.
Yes, I can delete that element if I edit & build https://github.com/LycheeOrg/Lychee-front. But,
I don't want to do it. Because, if I fork it I have to sync upstream with my forked repo.

Implementation

I implemented this option naming to sharable. It behaves just like downloadable.
The current public album & photo will be sharable = true automatically when migrate the database.

Others

Maybe I can't backport to this feature to less than v4.

Thank you :)

[ildyria]

I would change the wording.
"Visitors of your gallery can share this album."

It is untrue that you are preventing the sharing if you untick the box.

I would say something more in the like "display social media sharing links".

I think you are missing

define(BOOL, '0|1');

in your migration file.

[yoshinorin]

@ildyria
Thank you :)
I was just about to fix define(BOOL, '0|1');.

I would change the wording.
It is untrue that you are preventing the sharing if you untick the box.

OK.
I will change all of sharable (database value, variable name, etc) to another naming as well.

[codecov-io]

Codecov Report

Merging #403 into master will increase coverage by 1.21%.
The diff coverage is 61.53%.

[yoshinorin]

@ildyria
I updated PR and add some fixes.

• sharable to share_button_visible
  • I was wondering whether to use the word visibility. However, I think visibility can take values other than bool(true, false), So, I decide to use visible
• Return share_button_visible from PhotoController.
  • I forgot to update PhotoController when I first time submitted this PR
• Update all languages explanation.
  • Just copy English
  • Should I translate all language using by Google Translate?

As you notice my English is not good. Please tell me if you come up with better naming. I will update again and again :)

Screenshots

Othres

Should I squash and force push?

Thank you :)

[ildyria]

Should I squash and force push?

No need, we usually directly "Squash and merge" the PR. :)

[ildyria]

I'm working on tmp-hallenser PR and then I'll look at yours. 👍

[ildyria]

Lokks pretty good to me. 😃