Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Guzzle7 instead of Guzzle6. Fixes #998. #999

Merged
merged 1 commit into from
May 14, 2021
Merged

Use Guzzle7 instead of Guzzle6. Fixes #998. #999

merged 1 commit into from
May 14, 2021

Conversation

d7415
Copy link
Contributor

@d7415 d7415 commented May 9, 2021

Fixes #998

We now install Guzzle7, not Guzzle6.

This is completely untested. If we could use an unversioned Guzzle call here it might save a repeat occurrence.

@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #999 (1144583) into master (10927c6) will decrease coverage by 1.56%.
The diff coverage is 0.00%.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need someone to test this.

@d7415
Copy link
Contributor Author

d7415 commented May 9, 2021

Merging #999 (1144583) into master (10927c6) will decrease coverage by 1.56%.

Every time I read one of these, I wonder why we bother using a service that can't count....

@ildyria
Copy link
Member

ildyria commented May 9, 2021

Merging #999 (1144583) into master (10927c6) will decrease coverage by 1.56%.

Every time I read one of these, I wonder why we bother using a service that can't count....

It is because the "path" in the Update check is different if you are on master or on a branch.

@ildyria ildyria merged commit 914abd5 into master May 14, 2021
@ildyria ildyria deleted the fix-998 branch May 14, 2021 09:14
@joszz
Copy link

joszz commented Jun 2, 2021

For what it's worth, I ran into this issue and updated to current master, which has resolved it. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Class 'Http\Adapter\Guzzle6\Client' not found" when trying to convert GPS data
3 participants