Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LycheeOrg/Lychee#1896): Add guide for analytics tools #89

Merged
merged 3 commits into from
Jun 12, 2023
Merged

feat(LycheeOrg/Lychee#1896): Add guide for analytics tools #89

merged 3 commits into from
Jun 12, 2023

Conversation

timo-reymann
Copy link
Contributor

Documentation follow-up as mentioned in LycheeOrg/Lychee#1869.

It can be merged after LycheeOrg/Lychee#1870

Changes:

  • Guide for external trackign tools (Matomo, Google Analytics etc)
  • Reformat python script
  • Use string templates for inline string concat in generate script to be more consistent

Timo Reymann and others added 3 commits June 7, 2023 15:57
style: Reformat code
d2f55f1 
- Use format strings for inline usage
- Add new lines according to python style guide
feat: Add tracking docs
b01369b
@ildyria
fix gen.py
9dd64a4
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria
Copy link
Member

ildyria commented Jun 12, 2023

Found a type which would have broken the full doc. :')
LGTM.

@ildyria ildyria merged commit 02dccff into LycheeOrg:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timo-reymann @ildyria