Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single values for keywords #39

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Support single values for keywords #39

merged 4 commits into from
Apr 14, 2022

Conversation

kamil4
Copy link

@kamil4 kamil4 commented Apr 14, 2022

Fixes #37 and LycheeOrg/Lychee#1237

Co-authored by: z-jun

@kamil4 kamil4 requested review from ildyria, d7415 and nagmat84 April 14, 2022 03:36
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor change request to replace a function call by a language construct.

tests/PHPExif/Mapper/ExiftoolMapperTest.php Outdated Show resolved Hide resolved
Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
@kamil4 kamil4 merged commit a4e6f5c into master Apr 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-1237 branch April 14, 2022 22:25
@kamil4 kamil4 mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on files with both IPTC:Keywords and XMP-dc:Subject set to single value
2 participants