Fix 1548 #55
Merged
Fix 1548 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The added images triggered some more issues with the recent rounding changes from #54 but this should be all good now... |
qwerty287
reviewed
Oct 22, 2022
|
To fix the codecov status you have to add some more tests to increase the coverage :D |
|
Kudos, SonarCloud Quality Gate passed!
|
ildyria
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LycheeOrg/Lychee#1548
When I added a few more test images I realized how incomplete our support was across multiple adapters so I patched up what I could:
MapperAbstractclass which implements one method: a recursivetrim.UTF8 handling is still hit-and-miss though. For instance, the ImageMagick adapter tends to just replace "strange" characters with a dot (
.). I added an invocation ofconvertToUTF8(which we use in other adapters) in the hope of fixing it but it didn't seem to improve anything. For best results, one should use Exiftool (as always, really...).