Lt 5595 migrate to net 8 new #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 16, 2024 16:36
|
| @@ -231,7 +231,7 @@ public Dictionary<string, List<CompiledScheduleTimeInterval>> GetMarketsTradingS | |||
|
|
|||
| try | |||
| { | |||
| return _compiledMarketScheduleCache.ToDictionary(); | |||
| return MoreEnumerable.ToDictionary(_compiledMarketScheduleCache); | |||
There was a problem hiding this comment.
In the [AssetPairsCache] class MoreEnumerable is replaced by
return pairsEnum.DistinctBy(p => p.Item1).ToDictionary();
Here it's the opposite, the normal enumerable replaced by MoreEnumerable
Why is this needed?
There was a problem hiding this comment.
It will not be replaced. The MoreLinq extension was used here before so as not to change the behaviour, I continued to use it. A semantic change is required due to a conflict between MoreLinq's implementation of the ToDictionary method and the new implementation of System.Linq in NET 8.
| @@ -358,7 +358,7 @@ public Dictionary<string, MarketState> GetMarketState() | |||
|
|
|||
| try | |||
| { | |||
| return _marketStates.ToDictionary(); | |||
| return MoreEnumerable.ToDictionary(_marketStates); | |||
| <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute> | ||
| <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute> | ||
| <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute> | ||
| <Version>2.32.0</Version> |
gponomarev-lykke
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.