Fix build - remove setuptools-git-versioning from pyproject.toml and also versioneer.py from MANIFEST #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was removed in 2ce7dbc awhile back to switch to use setuptools_scm.
…tuptools-git-versioning
I believe it is the addition of both setuptools-scm and
setuptools-git-versioning which caused confusion and incorrect operation on CI
-- it failed then to trigger the scm since I guess with
setuptools-git-versioning it was already getting some version according to
DEBUG:
DEBUG setuptools_scm._integration.setuptools infer_version {'name': None, 'version': '1.6.3.post5+git.13caf5c5', 'author': None, 'author_email': None, 'maintainer': None, 'maintainer_email': None, 'url': None, 'license': None, 'description': None, 'long_description': None, 'keywords': None, 'platforms': None, 'classifiers': None, 'download_url': None, 'provides': None, 'requires': None, 'obsoletes': None}
DEBUG setuptools_scm._integration.setuptools dist 139796115184528 139796115184848
running egg_info
so as you can see setuptools_scm just didn't bother running anything.
Should address #93
yarikoptic
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 2 2
Lines 385 385
=======================================
Hits 370 370
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… we did not remove
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Closes #93 - IMHO the main problem was having both setuptools-git-versioning and setuptools_scm which are for the same purpose, thus likely interfered.
I did some testing on my own repo in this branch for a while to arrive to this conclusion. e.g sample log