Skip to content

Bump AvaloniaVersion from 11.2.2 to 11.2.3 #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@
</PropertyGroup>

<PropertyGroup>
<AvaloniaVersion>11.2.2</AvaloniaVersion>
<AvaloniaVersion>11.2.3</AvaloniaVersion>
</PropertyGroup>

<PropertyGroup>

Unchanged files with check annotations Beta

unsafe
{
fixed (void* src = &_bitmapBackBuffer[0])

Check warning on line 429 in Avalonia.Gif/Decoding/GifDecoder.cs

GitHub Actions / build

Dereference of a possibly null reference.

Check warning on line 429 in Avalonia.Gif/Decoding/GifDecoder.cs

GitHub Actions / build

Dereference of a possibly null reference.
Buffer.MemoryCopy(
src,
targetPointer.ToPointer(),
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static int ReadBlock(this Stream stream, byte[] tempBuf)
{
stream.Read(tempBuf, 0, 1);

Check warning on line 26 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 26 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
var blockLength = (int)tempBuf[0];
if (blockLength > 0)
stream.Read(tempBuf, 0, blockLength);

Check warning on line 31 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 31 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
// Guard against infinite loop.
if (stream.Position >= stream.Length)
int blockLength;
do
{
stream.Read(tempBuf, 0, 1);

Check warning on line 49 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 49 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
blockLength = tempBuf[0];
stream.Position += blockLength;
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static ushort ReadUShortS(this Stream stream, byte[] tempBuf)
{
stream.Read(tempBuf, 0, 2);

Check warning on line 66 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 66 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
return SpanToShort(tempBuf);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static byte ReadByteS(this Stream stream, byte[] tempBuf)
{
stream.Read(tempBuf, 0, 1);

Check warning on line 76 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 76 in Avalonia.Gif/Extensions/StreamExtensions.cs

GitHub Actions / build

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
var finalVal = tempBuf[0];
return finalVal;
}
public string? RelativePath { get; set; }
public SourceCache<TObject, TKey> ItemsSource { get; }

Check warning on line 15 in StabilityMatrix.Core/Models/IndexCollection.cs

GitHub Actions / build

The type 'TObject' cannot be used as type parameter 'TObject' in the generic type or method 'SourceCache<TObject, TKey>'. Nullability of type argument 'TObject' doesn't match 'notnull' constraint.

Check warning on line 15 in StabilityMatrix.Core/Models/IndexCollection.cs

GitHub Actions / build

The type 'TObject' cannot be used as type parameter 'TObject' in the generic type or method 'SourceCache<TObject, TKey>'. Nullability of type argument 'TObject' doesn't match 'notnull' constraint.
/// <summary>
/// Observable Collection of indexed items
public IndexCollection(
IImageIndexService imageIndexService,
Func<TObject, TKey> keySelector,
Func<IObservable<IChangeSet<TObject, TKey>>, IObservable<IChangeSet<TObject, TKey>>>? transform = null

Check warning on line 25 in StabilityMatrix.Core/Models/IndexCollection.cs

GitHub Actions / build

The type 'TObject' cannot be used as type parameter 'TObject' in the generic type or method 'IChangeSet<TObject, TKey>'. Nullability of type argument 'TObject' doesn't match 'notnull' constraint.

Check warning on line 25 in StabilityMatrix.Core/Models/IndexCollection.cs

GitHub Actions / build

The type 'TObject' cannot be used as type parameter 'TObject' in the generic type or method 'IChangeSet<TObject, TKey>'. Nullability of type argument 'TObject' doesn't match 'notnull' constraint.
)
{
this.imageIndexService = imageIndexService;
public override Dictionary<SharedFolderType, IReadOnlyList<string>>? SharedFolders { get; }
public override Dictionary<SharedOutputType, IReadOnlyList<string>>? SharedOutputFolders { get; }
public override Task<DownloadPackageVersionOptions> GetLatestVersion(bool includePrerelease = false)

Check warning on line 147 in StabilityMatrix.Core/Models/Packages/UnknownPackage.cs

GitHub Actions / build

Nullability of reference types in return type doesn't match overridden member.

Check warning on line 147 in StabilityMatrix.Core/Models/Packages/UnknownPackage.cs

GitHub Actions / build

Nullability of reference types in return type doesn't match overridden member.
{
throw new NotImplementedException();
}
[ConfigComment(
"How to launch the UI. If 'none', just quietly launch.\nIf 'web', launch your web-browser to the page.\nIf 'webinstall', launch web-browser to the install page.\nIf 'electron', launch the UI in an electron window (NOT YET IMPLEMENTED)."
)]
[ManualSettingsOptions(Impl = null, Vals = new string[] { "none", "web", "webinstall", "electron" })]

Check warning on line 63 in StabilityMatrix.Core/Models/FDS/StableSwarmSettings.cs

GitHub Actions / build

Cannot convert null literal to non-nullable reference type.

Check warning on line 63 in StabilityMatrix.Core/Models/FDS/StableSwarmSettings.cs

GitHub Actions / build

Cannot convert null literal to non-nullable reference type.
public string LaunchMode = "webinstall";
[ConfigComment("The minimum tier of logs that should be visible in the console.\nDefault is 'info'.")]