Skip to content

Enable tag searching in model metadata #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohnjiles merged 1 commit into from
Mar 21, 2025
Merged

Enable tag searching in model metadata #1187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions StabilityMatrix.Avalonia/ViewModels/CheckpointsPageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,15 @@ protected override async Task OnInitialLoadedAsync()
(Func<LocalModelFile, bool>)(
file =>
string.IsNullOrWhiteSpace(SearchQuery)
|| (
SearchQuery.StartsWith("#")
&& (
file.ConnectedModelInfo?.Tags.Contains(
SearchQuery.Substring(1),
StringComparer.OrdinalIgnoreCase
) ?? false
Comment on lines +219 to +222
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding an explicit null check for file.ConnectedModelInfo?.Tags before calling Contains. While the ?? false handles the null case, an explicit check would improve readability and make the intent clearer.

Also, it might be beneficial to add a comment explaining why StringComparer.OrdinalIgnoreCase is used for the tag comparison. This clarifies the intended behavior, especially if there are other comparison options to consider.

                                    file.ConnectedModelInfo?.Tags != null && file.ConnectedModelInfo.Tags.Contains(
                                        SearchQuery.Substring(1),
                                        StringComparer.OrdinalIgnoreCase // Case-insensitive comparison for tag search
                                    ) ?? false

)
)
|| file.DisplayModelFileName.Contains(
SearchQuery,
StringComparison.OrdinalIgnoreCase
Expand Down
Loading