-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Non-git mixin #8
[WIP] Non-git mixin #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for working on this, @Wauplin.
I think we can merge this and then ask others for review on the original PR.
The documentation is not available anymore as the PR was closed or merged. |
Thanks @LysandreJik for the review. I'll fix the few things you highlighted and then merge it to continue the discussion on the "real" PR :) |
…gface_hub into wauplin-non-git-mixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for iterating @Wauplin!
Disclaimer: I made quite some mess with the branch/fork so this PR might be temporary one that we close without merging. I created a branch
wauplin-non-git-mixin
from themain
of the main repo and merged the branch non-git-mixin from @LysandreJik's fork. My goal was just to start with a clean state once the merge conflicts were resolved. This PR is quite huge because of the new features from themain
branch. To see what huggingface#847 would be after merging see, see the diff comparison (I would rather not start a new PR from this branch tomain
directly just to avoid losing the previous discussion in huggingface#847).What is done ?
main
upload_folder
in both hub and keras mixinsWhat remains ?
--> donesave pretrained
-> signature changes to returnList[str]
instead ofNone
. Does it impact other subclasses and how ? Document it (see comment).- adapt tests (and create new ones)-> done- deprecate previous arguments (-> donerepo_path_or_name
,repo_url
,use_auth_token
,git_user
,git_email
)- deprecate-> doneskip_lfs_files
-> introduced in huggingface#858 . For what I understand from this comment,skip_lfs_files
is now useless since we do not pull the repo anyway => to be deprecatedHow to deprecate arguments ?
I am still wondering what is the policy to deprecate things without breaking changes.
*
to force the usage of keyword arguments. Do you confirm ?_deprecate_positional_args
? I didn't find any but maybe you already have this in another repo ?a. Will work:
use_auth_token
. I feel it's fine because we can take the token from eithertoken
oruse_auth_token
and both old and new behaviour work.b. Will not always work:
repo_path_or_name
. What if the user is passing a path to a local directory on its machine ? We cannot handle it with the new behaviour. Does it mean we still need the old implementation withRepository
as well and make it live until next release ? I am a bit afraid of "dead code" if we do like this. Any opinion ?I am also fine with merging this PR to Lysandre's repo and then continue the discussion in huggingface#847