Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #21

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Bug fixes #21

merged 7 commits into from
Mar 20, 2024

Conversation

gargimaheshwari
Copy link
Member

Description

Closes LYZ-229, LYZ-230, LYZ-231, LYZ-232, LYZ-233

What: Bugs

  1. change Bitwise a|b to Union Union[a, b]
  2. The default count for tasks is 3 instead of 5 in line 535 in analyzr.py
  3. log_filename throws an error if the parent directory doesn't exist
  4. plot_utils.py requires plot_path to exist

Why: They were errors or buggy-behavior
How: No major changes were needed.

  1. changed a|b to Union[a, b]
  2. made n_tasks: Optional[int] = 5 line 535 in analyzr.py
  3. create the parent directory
  4. use open(filename, 'w').close() to "create the file"

What type of PR is this?

  • 🎁 New feature (non-breaking change which adds functionality)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 💣 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Refactor or style update
  • 🔥 Performance improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI, review, release, devops, chore, etc.

Added tests?

  • ☑️ Yes
  • ❎ No, and this is why: Testing framework not yet set up
  • ❓ No, because I need help.

Checklist:

  • 😎 My code follows the style guidelines of this project.
  • ☑️ I have performed a self-review of my code.
  • 📑 I have commented my code, particularly in hard-to-understand areas.
  • 🔖 I have made corresponding changes to the documentation.
  • ⚠️ My changes generate no new warnings.
  • 🧐 I have added tests that prove my fix is effective or that my feature works.
  • ✅ New and existing unit tests pass locally with my changes.
  • 🔗 Any dependent changes have been merged and published in downstream modules.

@gargimaheshwari gargimaheshwari merged commit 214f79a into main Mar 20, 2024
1 check failed
@gargimaheshwari gargimaheshwari deleted the feat/txt-to-sql branch April 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants