Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modified default index naming in vector_store to use a unique identifier #9

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

patel-lyzr
Copy link
Collaborator

@patel-lyzr patel-lyzr commented Jan 16, 2024

Description

What: Modified default index naming in vector_store to use a unique identifier
Why: Enhancing data isolation and avoiding potential naming conflicts in vector store.
How: Utilized uuid for unique vector-store index name.

What type of PR is this?

  • 🎁 New feature (non-breaking change which adds functionality)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 💣 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Refactor or style update
  • 🔥 Performance improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI, review, release, devops, chore, etc.

Added tests?

  • ☑️ Yes
  • ❎ No, and this is why:
  • ❓ No, because I need help.

How can this be tested?

Test A

  • Description:
  • Test Configuration:
  • Test Instructions:
  • Libraries:
  • Expected Result:

[optional] Are there any post-deployment tasks we need to perform?

Checklist:

  • 😎 My code follows the style guidelines of this project.
  • ☑️ I have performed a self-review of my code.
  • 📑 I have commented my code, particularly in hard-to-understand areas.
  • 🔖 I have made corresponding changes to the documentation.
  • ⚠️ My changes generate no new warnings.
  • 🧐 I have added tests that prove my fix is effective or that my feature works.
  • ✅ New and existing unit tests pass locally with my changes.
  • 🔗 Any dependent changes have been merged and published in downstream modules.

Required links:

  • Linear Issue:
  • Testing Notebook (Colab):
  • Code Documentation (Confluence):
  • User Documentation (Confluence):

Contributors:

@patel-lyzr patel-lyzr merged commit 98e1cd8 into main Jan 27, 2024
@patel-lyzr patel-lyzr deleted the wip-khush/refactor-chatbot branch February 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants