Extension safety #74
Merged
Extension safety #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluding markymark
…he url opening behavior. - Support running Extensions and using extensionContext to open url's - Support i.e. opening urls in a internal Safari View Controller instead of the open url behavior
This was referenced Nov 21, 2018
M2Bas
reviewed
Nov 22, 2018
...out Builders/UIView/Block Builders/Inline/InlineAttributedStringViewLayoutBlockBuilder.swift
Outdated
Show resolved
Hide resolved
Co-Authored-By: jvanzummeren <j.van.zummeren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different approach of #72 by @mhoeller-clue, who requested markymark to support extensions in #71
This pull request will allow markymark to compile in extension by using NSSelectorFromString("sharedApplication") instead using UIApplication.shared directly.
Also, this pull request will allow customization of the open url behavior by providing an implementation of URLOpener.
Added a TodayExtension target to demonstrate markymark is working with extensions