Fix CRLF handling when reading master playlist #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic breaks when `\r` is present in the playlist. There was special handling for the URI line, but in certain cases (example: audio stream with URI at the end) it broke other lines too. M3U8LineReader is already used when reading media playlists and solves the issue in a clean way.
|
@wolfcon in the source file I changed there were two comments in Chinese. I was wondering what they meant and used Google to translate them to English. The translation makes sense, so I modified the code. |
|
Also removed a utility function not used anymore. I hope this is okay. |
|
One last thing: this change is done against master which contains the SPM refactor. If you think it will take time to release it, I can also prepare it to be released as 0.4.1. |
wolfcon
reviewed
Apr 20, 2020
|
Already release 0.4.1 (spm included) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use M3U8LineReader when reading master playlist.
The existing logic breaks when
\ris present in the playlist. There was special handling for the URI line, but in certain cases (example: audio stream with URI at the end) it broke other lines too.M3U8LineReader is already used when reading media playlists and solves the issue in a clean way.