Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

[BUG] Theme White Checks not visible #1057

Closed
ghost opened this issue Jan 3, 2014 · 7 comments
Closed

[BUG] Theme White Checks not visible #1057

ghost opened this issue Jan 3, 2014 · 7 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 3, 2014

Hello,

If I use the white theme I can not see if something is checked or not as the checks have a white color and the background is also white.

In the black theme everything looks nice.

@M66B
Copy link
Owner

M66B commented Jan 3, 2014

@jpeg729 maybe it is an idea to calculate the brightness for the activated highlight color and compare this to the brightness of the background color and invert the color if the difference is to small.

https://github.com/M66B/XPrivacy/blob/master/src/biz/bokhorst/xprivacy/Util.java#L406

Not very good researched, maybe there are a built-in Java functions:
http://stackoverflow.com/questions/596216/formula-to-determine-brightness-of-rgb-color
http://stackoverflow.com/questions/1165107/how-do-i-invert-a-colour-color-c-net

Although inverting colors near gray will not make much difference.

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 3, 2014

I'll see what I can do

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 3, 2014

My idea would be to calculate the contrast with the background colour, and if necessary darken/lighten the highlight color. Similar calculations should probably enter into the multi-choice mode highlight colour.

@M66B
Copy link
Owner

M66B commented Jan 3, 2014

Do I smell here some nice baking? ;-)

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 3, 2014

Not quite yet unfortunately.

M66B pushed a commit that referenced this issue Jan 4, 2014
M66B pushed a commit that referenced this issue Jan 4, 2014
@M66B
Copy link
Owner

M66B commented Jan 4, 2014

Could you please try if this version solves the problem: http://d-h.st/h8L

@M66B
Copy link
Owner

M66B commented Jan 7, 2014

I am assuming the test version worked.
If not, please leave a comment.

@M66B M66B closed this as completed Jan 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants