Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Issue with random@boot #1164

Closed
an0n981 opened this issue Jan 26, 2014 · 10 comments
Closed

Issue with random@boot #1164

an0n981 opened this issue Jan 26, 2014 · 10 comments
Labels

Comments

@an0n981
Copy link
Contributor

an0n981 commented Jan 26, 2014

Setting random@boot to 'use global data' reverts to 'random at boot' after reboot. However running a select on the setting db shows the proper value null. I have tested this on uid 1000, google play store and afwall+ (user app)

@an0n981
Copy link
Contributor Author

an0n981 commented Jan 26, 2014

I also tested this on https://play.google.com/store/apps/details?id=aws.apps.networkInfoIi to see which dataset it receives

I have found that it can now read my real data. I don't know if this has something to do with changing the setting or if the issue was there prior to changing it

@an0n981
Copy link
Contributor Author

an0n981 commented Jan 26, 2014

Edit: after another reboot the app now receives app specific fake data, the check is set to random at boot, the db shows null=use global fake dataa

@M66B
Copy link
Owner

M66B commented Jan 26, 2014

This is a good find!
The problem was caused be recent code refactoring.

@M66B
Copy link
Owner

M66B commented Jan 26, 2014

@an0n981 can you please try if this version does fix the problem: http://d-h.st/rKf

Thanks for all your bug reports!

Is the issue with the database inconsistencies solved now?
Isn't the new database fun? ;-)

@an0n981
Copy link
Contributor Author

an0n981 commented Jan 26, 2014

Now instead of resetting to random at boot, it resets to both random at boot and use global data unchecked. The db still shows random@boot as null. Apps that have random at boot set save the setting properly.

I will do some extensive testing on the db tomorrow and report anything newsworthy

@M66B M66B closed this as completed in 02d6591 Jan 27, 2014
@an0n981
Copy link
Contributor Author

an0n981 commented Jan 27, 2014

Now unchecking 'use global data' does not stick

@M66B
Copy link
Owner

M66B commented Jan 27, 2014

There is one other thing to fix/improve:

"saving an empty fake value will result in using the empty value, instead of the global value"

@M66B M66B reopened this Jan 27, 2014
@M66B M66B closed this as completed in 9e8218f Jan 27, 2014
@M66B
Copy link
Owner

M66B commented Jan 27, 2014

@an0n981 could you please test this version: http://d-h.st/yMy

NULL settings values are not stored into the database anymore and existing NULL values will be deleted from the database on reboot after installing this version.

Empty application settings in the dialog are deleted from the database, so the global setting will be used (if any).
This allows for a mix between specific (setting value set in the application settings dialog) and global settings (value not set in the application settings dialog).

@an0n981
Copy link
Contributor Author

an0n981 commented Jan 27, 2014

Very nice. Everything working as promised

@M66B
Copy link
Owner

M66B commented Jan 27, 2014

Thanks for testing!

This saves some data, which is good for performance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants