-
Notifications
You must be signed in to change notification settings - Fork 527
Translations: String formatting migrated to positional format #1344
Conversation
These changes render pending pull request (issue M66B#1122) obsolete.
Do not pull yet. There seem to be replacement errors in -ar / -he / -ku / -fa files. |
@M66B : I have checked the files again. Obviously only right-to-left scripts are affected. Probably the files are correct, but incorrectly displayed only (e.g. "1% xxxx $d" instead of "xxxx %1$d"). I was puzzled after I followed the link to the translations above and found that the arabic translation did not look as expected. I tried to make the same changes manually using my editor and the same result occurred. I hope Android will interpret the strings as intended. Things also change in the editor when a different character set is selected (ANSI, UTF, ...), so the sequence of characters seems to be as expected. |
msg_licensed deleted
Recent change by M66B included.
French and German Translation Update |
Change applied to new malayan translation.
Change applied to new Malayan translation. |
Thanks for updating, @Phylon ! |
No, sorry, no tests done so far. I only browsed through the files for a short check. |
@Phylon building is pretty easy. If you need help, it is just one question away. |
Making German Translation available for upcoming stable release (from pending pull request issue M66B#1344).
Making French Translation available for upcoming stable release (from pending pull request issue M66B#1344).
Quote:"You could install 1.11 stable, set some restriction and then migrate this restriction by installing 1.99.x" I don't know how to build 1.11. I cannot find a tag for 1.11 in the repo. Also, I have not been able to get the "app_notxposed" message. I both disabled and uninstalled Xposed, but I only got "Privacy service not found...", when I opened XPrivacy. When I installed an older Xposed version, I got the same screen. Xprivacy could not be activated in the older Xposed installer, which is indicating that a newer Xposed bridge version is needed. Do you have some hints for me? |
There is no tag for 1.11, so that is right. I have only recently started using tags. |
I have decided not to merge this for all languages. Everything works okay and this change has the risk of breaking things. Nevertheless this is a good change, so my proposal is to make a merge request for the default English texts only and to provide a script in the tools folder, so that each translator can run this when updating a translation (or I will do this after an update has been provided). |
If this is the way you wish to go, I can do that. At least, I am now well trained in resolving language file merge conflicts.... |
Yes, please |
Cleanup done as a part of issue #1446. |
These changes render pending pull request (issue #1122) obsolete.