Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

UI update : 3-states checkboxes + filter app user/system/both #586

Closed
wants to merge 8 commits into from

Conversation

tonymanou
Copy link
Contributor

Finally got a good result for the three-states checkboxes !

  • Added three-states checkboxes in main activity
  • Improved accessibility : clickable images are focusable with DPAD in filter frame
  • Added the ability to show apps from user/system/both (new strings added)
  • Added infos about the user/system/both icons in help section
  • Various fixes

checkboxes

@LazyZhu
Copy link
Contributor

LazyZhu commented Aug 27, 2013

Great works for the three-states checkbox, 👍
I‘m looking forward to test it.
Please look into the issue #263 (list unchecked boxes)

@M66B
Copy link
Owner

M66B commented Aug 27, 2013

Merged manually, due to conflicts.

Thanks for all the work, Tony!

@M66B M66B closed this Aug 27, 2013
@LazyZhu
Copy link
Contributor

LazyZhu commented Aug 27, 2013

@tonymanou
How about changing Filter on restricted to Filter by restrict state (three-states) just like Filter by application type?

@LazyZhu
Copy link
Contributor

LazyZhu commented Aug 27, 2013

@tonymanou @M66B
I'm testing with 1.9.8 now.
Bug or not?
Applications with only dangerous restricted are not be counted as 3th-state.

@M66B
Copy link
Owner

M66B commented Aug 27, 2013

@LazyZhu create an issue for new feature request to prevent they get lost here

@M66B
Copy link
Owner

M66B commented Aug 27, 2013

@LazyZhu dangerous does not matter for the check boxes. I cannot reproduce your issue. Can you describe the exact steps to reproduce?

@LazyZhu
Copy link
Contributor

LazyZhu commented Aug 27, 2013

@M66B
For example, I only restricted Autostarts's Internet, and on the app list shows Autostarts unchecked.
screenshot_2013-08-27-15-44-26
screenshot_2013-08-27-15-44-58

@M66B
Copy link
Owner

M66B commented Aug 27, 2013

Please post a screen shot with internet drilled down for Autostarts, so we can see the function exceptions.

@LazyZhu
Copy link
Contributor

LazyZhu commented Aug 27, 2013

All internet restricted.

@M66B
Copy link
Owner

M66B commented Aug 27, 2013

Please create an issue for this.

@tonymanou
Copy link
Contributor Author

Ow nooo, manually merged °J°.. Due to the translation pulled before I think. It's not good for my stats :p (just kidding)

@LazyZhu
You are right about Filter by restrict state, it's better. But I can't change it now for all languages without doing 30 commits like pylerSM because I'm at work and I can only use github's web interface.
Edit : My mistake, I though you were talking about changing the string.

@M66B
What do you think about LazyZhu's idea forFilter by restrict state ?

@tonymanou tonymanou deleted the 3rdstate branch August 27, 2013 08:57
@tonymanou
Copy link
Contributor Author

I just added a fix for issue #591, in order to show a half-ticked checkbox when an app has only dangerous restrictions set.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants