Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH key uploads not working #850

Closed
anilnatha opened this issue Oct 26, 2023 · 4 comments · Fixed by MAAP-Project/maap-workspaces#100
Closed

SSH key uploads not working #850

anilnatha opened this issue Oct 26, 2023 · 4 comments · Fixed by MAAP-Project/maap-workspaces#100
Assignees
Labels
Bug Something isn't working JPL JPL related issues
Milestone

Comments

@anilnatha
Copy link

Describe the bug

The SSH upload feature in the portal doesn't work as expected. After submitting your public ssh key, no status of the upload process or of the ssh key info is saved to your profile.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the MAAP OPS Portal
  2. Login
  3. Visit your profile page
  4. Scroll down to 'Public SSH Key' section
  5. Try uploading your SSH public key

Expected behavior

After submitting your SSH public key, a user should be informed that the process was successful and the UI should list the name of the SSH public key file that was uploaded and added to the user's account.

Screenshots

Screen Shot 2023-10-26 at 13 07 27
@anilnatha anilnatha self-assigned this Oct 26, 2023
@anilnatha anilnatha added the Bug Something isn't working label Oct 26, 2023
@anilnatha
Copy link
Author

This issue was reported by @rtapella

@marjo-luc
Copy link
Member

I don't think there are issues with the upload. I was able to upload a public key and retrieve it from my workspace using this snippet:

'''
from maap.maap import MAAP
maap = MAAP(maap_host='api.dit.maap-project.org')

r = maap.profile.account_info()
print(r)
'''

We should probably provide users with feedback on the upload, though, and also list available keys.

@anilnatha
Copy link
Author

Investigated the issue, looks like we are no longer returning the fields needed to display ssh key information when making a call to the /members/:key endpoint.

Will add the fields back to this endpoint and test.

@anilnatha
Copy link
Author

The fixes we applied to maap-api addressed the issue and the resolution was verified to be working in DIT.

We need to promote the change to UAT for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working JPL JPL related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants