Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial config without riotiler #48

Merged
merged 8 commits into from
Apr 18, 2023
Merged

Conversation

emmalu
Copy link
Collaborator

@emmalu emmalu commented Mar 24, 2023

rio-tiler and rioxarray packages both give the following:

ERROR: A GDAL API version must be specified. Provide a path to gdal-config using a GDAL_CONFIG environment variable or use a GDAL_VERSION environment variable.

@emmalu
Copy link
Collaborator Author

emmalu commented Mar 24, 2023

@wildintellect one thing that comes to mind is: should we 'mix' the use of both pip and conda to handle the different package installs? or perhaps move everything to be handled by conda?

@wildintellect
Copy link
Collaborator

wildintellect commented Mar 24, 2023

Generally move as much as possible to conda, I think is the right answer. Only resort to pip when conda doesn't have the right versions. But I'll look at this more closely.

@wildintellect
Copy link
Collaborator

wildintellect commented Mar 24, 2023

The bigger issue is that the pip is being run outside the conda environment. I dug deeper...

Options

  • Start with a different base image (we could reuse some of the method MS uses) or go the micromamba route (side note: this version of miniconda does not seem to have the libmamba solver - no idea why)
  • Try changing to root to add to the conda install, or change the permissions to make it all owned by vscode user. Technically worked but gave me some grief. @emmalu do you want a PR to your PR?
USER root
COPY environment.yml* .devcontainer/noop.txt /tmp/conda-tmp/
RUN if [ -f "/tmp/conda-tmp/environment.yml" ]; then umask 0002 && /opt/conda/bin/conda env update -n base -f /tmp/conda-tmp/environment.yml; fi \
    && rm -rf /tmp/conda-tmp

@wildintellect
Copy link
Collaborator

@emmalu I think I have a fix, see #49

fix: work around conda env loading error as root
Copy link
Collaborator

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is working now for @emmalu and @edkeeble then please proceed.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@emmalu emmalu merged commit 334f3de into main Apr 18, 2023
@wildintellect wildintellect deleted the add-devcontainer-configuration branch September 27, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants