Improve support for 4:3 aspect ratio cameras and higher resolution cameras #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional resolution steps to support higher resolution cameras in the future and to support more cameras today, specifically 4:3 aspect ratio cameras.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Some devices have 4:3 aspect ratio cameras. The current constraints don't allow those cameras to capture near their full quality because the provided constraints are too far above or below the full width of those cameras.
The issue we encountered specifically was that an 8MP webcam with a 4:3 aspect ratio (3264 x 2448) was falling all the way back to 2560 which was a very large dropoff in quality.
Proposed Solution: Add some additional constraints to better target more devices.
Alternatives: An alternative would be to allow passing constraints in so that we as consumers could make the list as comprehensive as we want, but that would require more work both here and in
react-html5-camera-photowhich uses this library as a dependency.