Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Some Implementations from ndShapeCompount.h to ndShapeCompount.cpp #267

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Move Some Implementations from ndShapeCompount.h to ndShapeCompount.cpp #267

merged 2 commits into from
Jan 23, 2022

Conversation

TrevorCash
Copy link
Contributor

No description provided.

@TrevorCash
Copy link
Contributor Author

Did this because compiler couldnt resolve ndShapeInstance because of the new statement:

inline ndShapeCompound::ndNodeBase::ndNodeBase(ndShapeInstance* const instance)
	:ndClassAlloc()
	, m_type(m_leaf)
	, m_left(nullptr)
	, m_right(nullptr)
	, m_parent(nullptr)
	, m_myNode(nullptr)
	, m_shapeInstance(new ndShapeInstance(*instance))
{
	CalculateAABB();
}

@TrevorCash
remove inline on some constructors. some more changes to get things t…
d5ec91f 
…o compile. perhaps the D_API's should be brought out to automatically expose all class members?
@JulioJerez JulioJerez merged commit 217922d into MADEAPPS:master Jan 23, 2022
@JulioJerez
Copy link
Contributor

merged, yes that's a good action. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorCash @JulioJerez